Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of Tensorflow model kserve Rest testcase UI -> API #2183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Raghul-M
Copy link
Contributor

No description provided.

Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Raghul-M

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -43,6 +43,9 @@
${PYTORCH_MODEL_NAME}= resnet50
${INFERENCE_REST_INPUT_PYTORCH}= @tests/Resources/Files/triton/kserve-triton-resnet-rest-input.json
${EXPECTED_INFERENCE_REST_OUTPUT_FILE__PYTORCH}= tests/Resources/Files/triton/kserve-triton-resnet-rest-output.json
${TENSORFLOW_MODEL_NAME}= inceptiongraphdef
${INFERENCE_REST_INPUT_TENSORFLOW}= @tests/Resources/Files/triton/kserve-triton-tensorflow-rest-input.json
${EXPECTED_INFERENCE_REST_OUTPUT_FILE_TENSORFLOW}= tests/Resources/Files/triton/kserve-triton-tensorflow-rest-output.json

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }})

Line is too long (126/120)
Comment on lines +262 to +263

Test Tensorflow Model Rest Inference Via API (Triton on Kserve) # robocop: off=too-long-test-case

Check warning

Code scanning / Robocop

Invalid number of empty lines between test cases ({{ empty_lines }}/{{ allowed_empty_lines }})

Invalid number of empty lines between test cases (2/1)
... AND
... Run Keyword If "${KSERVE_MODE}"=="RawDeployment" Terminate Process triton-process kill=true


Test Tensorflow Model Rest Inference Via API (Triton on Kserve) # robocop: off=too-long-test-case

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }})

Test case 'Test Tensorflow Model Rest Inference Via API (Triton on Kserve)' has too many keywords inside (13/10)
Test Tensorflow Model Rest Inference Via API (Triton on Kserve) # robocop: off=too-long-test-case
[Documentation] Test the deployment of Tensorflow model in Kserve using Triton
[Tags] Tier2 RHOAIENG-16910 RunThisTest
Setup Test Variables model_name=${TENSORFLOW_MODEL_NAME} use_pvc=${FALSE} use_gpu=${FALSE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }})

Line is too long (123/120)
Set Project And Runtime runtime=${KSERVE_RUNTIME_REST_NAME} protocol=${PROTOCOL} namespace=${test_namespace}
... download_in_pvc=${DOWNLOAD_IN_PVC} model_name=${TENSORFLOW_MODEL_NAME}
... storage_size=100Mi memory_request=100Mi
${requests}= Create Dictionary memory=1Gi

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR

Create Dictionary can be replaced with VAR
END
${EXPECTED_INFERENCE_REST_OUTPUT_TENSORFLOW}= Load Json File
... file_path=${EXPECTED_INFERENCE_REST_OUTPUT_FILE_TENSORFLOW} as_string=${TRUE}
Verify Model Inference With Retries model_name=${TENSORFLOW_MODEL_NAME} inference_input=${INFERENCE_REST_INPUT_TENSORFLOW}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }})

Line is too long (131/120)
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
600 0 0 600 100

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants