[Cherry-pick] Python fixes and CrashLoop Fix #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump paddlepaddle to 2.6.0 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Bump transformers to version 4.37.2 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Bump cryptography to version 42.0.2 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Bump fastapi to version 0.109.2 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Bump pillow to version 10.2.0 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Bump aiohttp to version 3.9.3 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Revert fastapi bump Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Bump ray serve to 2.9.2 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Pin alibi to >=0.9.4 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Fix alibi version Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
ValueError: `detached=False` is no longer supported. In a future release, it will be removed altogether. Signed-off-by: Spolti <fspolti@redhat.com>
* Allow ray 2.6.1 Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * PR suggestion Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Run poetry update --lock Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Support RayServeSyncHandle in ray>=2.5.0 Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Run poetry update --lock Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Correct hashFiles cache for sklearn Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Run poetry update --lock Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Avoid faulty tritonclient release Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Run poetry update --lock Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Add and run make poetry-update-lockfiles Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Refrain from private imports and make poetry-update-lockfiles Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Revert paddle to max 3.10 Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Revert "Revert paddle to max 3.10" This reverts commit a5afe2b. Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> --------- Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
Signed-off-by: Spolti <fspolti@redhat.com>
This enhances the setup of the InferenceService controller and the InferenceGraph controller. Instead of relying on the `defaultDeploymentMode` configuration to determine what CRDs to watch, the setup now checks whether KNative Services and Istio VirtualServices are available in the cluster and setup the watches (invoke `Owns`) accordingly. This enhancement has the following advantages: * A crashloop is prevented if the CRDs are missing in the cluster. The user would still be able to create InferenceServices by taking care of annotating the ISVC for RawDeployment mode. * If RawDeployment mode is configured as the default mode, the controllers would still watch for KNative and Istio resources if these components are available. This will let the controller watch for changes for the dependent resources if the user uses Serverless mode for some of the InferenceServices. * In the InferenceService controller, the watch for the VirtualServices is still conditioned to the value of the `disableVirtualHost` configuration.
spolti
approved these changes
Feb 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5b4f7fa
into
red-hat-data-services:rhoai-2.8
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cherry pick of: