Prevent remote function errors with actors #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasial-dev
reviewed
Jan 13, 2025
There was a problem hiding this comment.
I'm not sure how I feel about your change to be honest, as while it does fix the issue, it technically introduces the possibility for an event to be dropped which I don't like.
So I'll leave it open for a little and get some input from others.
(message from this Discord thread)
sasial-dev
requested changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there can be multiple Zap instances when using actors, there can be multiple
RemoteEvent.OnClientEventlisteners. Only the listener from the VM that fired the remote function will have a valid thread to resume execution at. This change simply ignores the remote function return on any other VM.Reported by Phoenix in ROSS.