Optimize event ids by splitting them up by server/client and reliable/unreliable #143
+412
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Event ids used to start at |
jackdotink
reviewed
Jan 6, 2025
Comment on lines
+35
to
+67
| pub fn server_reliable_count(&self) -> usize { | ||
| let reliable_count = self | ||
| .evdecls | ||
| .iter() | ||
| .filter(|evdecl| evdecl.from == EvSource::Client && evdecl.evty == EvType::Reliable) | ||
| .count(); | ||
|
|
||
| reliable_count + self.fndecls.len() | ||
| } | ||
|
|
||
| pub fn server_unreliable_count(&self) -> usize { | ||
| self.evdecls | ||
| .iter() | ||
| .filter(|evdecl| evdecl.from == EvSource::Client && evdecl.evty == EvType::Unreliable) | ||
| .count() | ||
| } | ||
|
|
||
| pub fn client_reliable_count(&self) -> usize { | ||
| let reliable_count = self | ||
| .evdecls | ||
| .iter() | ||
| .filter(|evdecl| evdecl.from == EvSource::Server && evdecl.evty == EvType::Reliable) | ||
| .count(); | ||
|
|
||
| reliable_count + self.fndecls.len() | ||
| } | ||
|
|
||
| pub fn client_unreliable_count(&self) -> usize { | ||
| self.evdecls | ||
| .iter() | ||
| .filter(|evdecl| evdecl.from == EvSource::Server && evdecl.evty == EvType::Unreliable) | ||
| .count() | ||
| } |
There was a problem hiding this comment.
why are we doing this instead of having separate reliable and unreliable counts?
There was a problem hiding this comment.
This allows for more events before increasing the ids. Imagine 256 reliable client to server events and 256 reliable server to client events. With how I've done it, that only needs a u8. If we combined them, it would need a u16. It's possible to separate them because the events are one-way.
I might have misunderstood the question though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all events and functions share event ids in the same pool. This is unnecessary and optimizing it will allow for more events/functions before needing to increase the bytes required for the event id.
To give an example, reliable events and functions are never sent through the unreliable remote. This means we can have separate pools of ids for reliable and unreliable.