Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sets #117

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Add sets #117

merged 5 commits into from
Jul 2, 2024

Conversation

Ketasaja
Copy link
Contributor

@Ketasaja Ketasaja commented Jul 1, 2024

Closes #83.

Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these minor things otherwise the code LGTM.

zap/src/irgen/ser.rs Show resolved Hide resolved
zap/src/output/typescript/mod.rs Outdated Show resolved Hide resolved
zap/src/output/typescript/mod.rs Outdated Show resolved Hide resolved
@sasial-dev sasial-dev self-assigned this Jul 2, 2024
@Ketasaja Ketasaja requested a review from sasial-dev July 2, 2024 08:30
zap/src/irgen/des.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sasial-dev sasial-dev merged commit 5d53f79 into red-blox:0.6.x Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants