Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remote scope option #107

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

EncodedVenom
Copy link
Contributor

@EncodedVenom EncodedVenom commented Jun 26, 2024

Changes the way zap remotes are created.

If the remote_scope option is set, the remote name will replace ZAP in remote names with the option set.

Closes #106. The motivation for this PR can be found in that issue.

Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather SCOPE_NAME was hardcoded in on the rust side instead of using template strings. If you need/want to delete client.luau and server.luau to do so, that doesn't bother me.

@sasial-dev sasial-dev self-assigned this Jun 26, 2024
@EncodedVenom EncodedVenom requested a review from sasial-dev June 26, 2024 08:40
zap/src/output/luau/server.luau Outdated Show resolved Hide resolved
zap/src/output/luau/client.rs Outdated Show resolved Hide resolved
zap/src/output/luau/server.rs Outdated Show resolved Hide resolved
zap/src/parser/convert.rs Show resolved Hide resolved
@EncodedVenom EncodedVenom requested a review from sasial-dev June 26, 2024 09:15
zap/src/output/luau/client.rs Outdated Show resolved Hide resolved
docs/.vitepress/components/Editor.vue Show resolved Hide resolved
EncodedVenom and others added 3 commits June 27, 2024 00:31
Co-authored-by: Sasial <44125644+sasial-dev@users.noreply.github.com>
@EncodedVenom EncodedVenom requested a review from sasial-dev June 27, 2024 04:54
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your patience with this one.

@sasial-dev sasial-dev merged commit 2add9dd into red-blox:0.6.x Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants