-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement remote scope option #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather SCOPE_NAME
was hardcoded in on the rust side instead of using template strings. If you need/want to delete client.luau
and server.luau
to do so, that doesn't bother me.
Co-authored-by: Sasial <44125644+sasial-dev@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your patience with this one.
Changes the way zap remotes are created.
If the
remote_scope
option is set, the remote name will replaceZAP
in remote names with the option set.Closes #106. The motivation for this PR can be found in that issue.