Remove benign shadowing #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasial-dev
reviewed
Jun 26, 2024
Ketasaja
force-pushed
the
remove-benign-shadowing
branch
from
a73e0d2 to
ff3b3fa
Compare
sasial-dev
requested changes
Jun 27, 2024
sasial-dev
requested changes
Jun 28, 2024
|
I kind of dislike the complexity being added here, and I still haven't handled cases like |
|
Maybe let's revert that commit then? I agree it's not the greatest approch to hide it. |
Ketasaja
force-pushed
the
remove-benign-shadowing
branch
from
1def570 to
ea794e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suffixes are less incremental than with
display_escaped_suffix, but there should be no shadowing left. I'm not aware of this being necessary to fix anything, unlike previous changes.