Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error code on diff with dry-run option #805

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Return error code on diff with dry-run option #805

merged 2 commits into from
Dec 3, 2018

Conversation

soullivaneuh
Copy link
Contributor

Fixes #800

@soullivaneuh
Copy link
Contributor Author

The failing CI is not related to the PR. A CS update is needed.

@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 3, 2018 •
edited
Loading

Please fix that too, so Travis is passing after merge

@soullivaneuh
Copy link
Contributor Author

@TomasVotruba Done.

@soullivaneuh
Copy link
Contributor Author

Well, now Travis want to revert my changes! https://travis-ci.org/rectorphp/rector/jobs/462834349 \o/

Any idea why? 😄

@soullivaneuh soullivaneuh mentioned this pull request Dec 3, 2018
Closed
@TomasVotruba
Copy link
Member

What command did you run?

@soullivaneuh
Copy link
Contributor Author 

bin/rector process src --level symfony40

The one which caused trouble on Travis first.

@TomasVotruba
Copy link
Member

I see a different one: https://travis-ci.org/rectorphp/rector/jobs/462834349#L653

@soullivaneuh
Copy link
Contributor Author

Indeed, but it's the command I found who did the exact same changes.

@TomasVotruba
Copy link
Member

But no troubles, I can handle this 👍

@TomasVotruba TomasVotruba merged commit 7528112 into rectorphp:master Dec 3, 2018
@TomasVotruba
Copy link
Member

Thank you

@soullivaneuh soullivaneuh deleted the dry-run-return-code branch December 3, 2018 15:46
@TomasVotruba
Copy link
Member

So that error is related to PHPStan && php-parser: print incompatibility: nikic/PHP-Parser#554 (comment)

I'll exclude the code in ecs.yml for now as workaround

What do you think?

@TomasVotruba
Copy link
Member

Let's see if this resolves it #806

TomasVotruba added a commit that referenced this pull request Aug 31, 2021
@TomasVotruba
Updated Rector to commit f74b7f6
e47937d 
rectorphp/rector-src@f74b7f6 [PHPStan] Clean up PHPStan ignore errors config (#805)
echo511 pushed a commit to echo511/rector that referenced this pull request Sep 4, 2021
@samsonasik
[PHPStan] Clean up PHPStan ignore errors config (rectorphp#805)
f74b7f6
@raziel057 raziel057 mentioned this pull request Aug 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soullivaneuh @TomasVotruba