-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scoped] Add more paths to downgrade, tweak scope configs #6382
Conversation
'(' | ||
); | ||
|
||
return $content; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be handled by Rector. If not, there is a bug somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this for handilng phpstan's vendor of ondrejmirtes/better-reflection/src
that somehow not downgrade the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All packages must be downgraded by Rector. scoper.php
is only for tweaking class names for autoload edge cases.
We need to figure out why this downgrade is missed. Maybe its in exlcuded paths in downgrade config for Rector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some probably caused by exclude config :
rector/build/config/config-downgrade-php70.php
Lines 51 to 63 in 6ddb145
'vendor/symfony/http-kernel/HttpKernelBrowser.php', | |
'vendor/symfony/http-foundation/Session/*', | |
'vendor/symfony/string/Slugger/AsciiSlugger.php', | |
'vendor/symfony/cache/*', | |
'nette/caching/src/Bridges/*', | |
// This class has an issue for PHP 7.1: | |
// https://github.com/rectorphp/rector/issues/4816#issuecomment-743209526 | |
// It doesn't happen often, and Rector doesn't use it, so then | |
// we simply skip downgrading this class | |
'vendor/symfony/dependency-injection/ExpressionLanguage.php', | |
'vendor/symfony/dependency-injection/ExpressionLanguageProvider.php', | |
'vendor/symfony/var-dumper/Caster/*', |
other probably need re-sort the directories.
I will check more.
rectorphp/rector-src@61016bf [CodeQuality] Use existing PhpAttributeAnalyzer service instead of AttributeFinder from Doctrine package on DynamicDocBlockPropertyToNativePropertyRector (#6382)
rectorphp/rector-src@61016bf [CodeQuality] Use existing PhpAttributeAnalyzer service instead of AttributeFinder from Doctrine package on DynamicDocBlockPropertyToNativePropertyRector (#6382)
reduce syntax errors from : 383 to 14:
Before:
After: