[prefixed] require compatible PHPStan with attribute phpdoc-parser #6181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
fix-phpstan
branch
from
a9cafe6 to
a0bbd6f
Compare
TomasVotruba
changed the title
samsonasik
reviewed
Apr 20, 2021
| @@ -7,11 +7,15 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^7.0|^8.0", | |||
| "phpstan/phpstan": "^0.9.3 || ^0.12.82" | |||
| "phpstan/phpstan": "^0.12.83" | |||
There was a problem hiding this comment.
@TomasVotruba it seems will make not installable by require prefixed from php 7
There was a problem hiding this comment.
after installed on php 7.3, the phpstan should be removed from composer.json to make it installable from php 7
There was a problem hiding this comment.
Yes, that's correct.
The PHPStan for PHP 7.0 must be:
- used from here https://github.com/phpstan/phpstan-src and downgraded to PHP 7.0
- or extracted from phpstan/phpstan phar file and downgraded to PHP 7.0
TomasVotruba
added a commit
that referenced
this pull request
Jul 24, 2024
rectorphp/rector-src@1aef755 [TypeDeclaration] Clean up get ClassReflection on loop on TypedPropertyFromCreateMockAssignRector (#6181)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6180