[TASK] Use rector-installer to load config of extensions #6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you make the CI pass first? The error is about PHPStan. I'll release new packages then |
sabbelasichon
force-pushed
the
issue-6129
branch
from
0b7c6a3
to
2be2257
Compare
|
@TomasVotruba I have moved the loading of the configs into the container configuration itself. Because the bootstrapping happens only by invoking the bin/rector.php |
sabbelasichon
commented
Apr 20, 2021
sabbelasichon
force-pushed
the
issue-6129
branch
from
2be2257
to
ab6bf65
Compare
sabbelasichon
force-pushed
the
issue-6129
branch
2 times, most recently
from
ca2fa6e
to
b7d8f8d
Compare
composer.json
Outdated
Comment on lines
43
to
49
| "rector/rector-cakephp": "dev-main", | ||
| "rector/rector-doctrine": "dev-main", | ||
| "rector/rector-installer": "dev-main", | ||
| "rector/rector-laravel": "dev-main", | ||
| "rector/rector-nette": "dev-main", | ||
| "rector/rector-phpunit": "dev-main", | ||
| "rector/rector-symfony": "dev-main", |
There was a problem hiding this comment.
I've just released ned version for these packages. Could you use them instead?
composer.json
Outdated
| @@ -73,7 +74,7 @@ | |||
| "nette/forms": "^3.0", | |||
| "phpstan/phpstan-nette": "^0.12.16", | |||
| "phpunit/phpunit": "^9.5", | |||
| "rector/rector-generator": "^0.1.5", | |||
| "rector/rector-generator": "dev-main", | |||
sabbelasichon
force-pushed
the
issue-6129
branch
from
5e544aa
to
bd0e322
Compare
composer.json
Outdated
| "rector/rector-doctrine": "^0.10.2", | ||
| "rector/rector-installer": "dev-main", |
There was a problem hiding this comment.
Could you tag this one too, so we can remove min-stability dev?
There was a problem hiding this comment.
I have also bumped it up to PHP Version 7.3
|
Thank you 👏 |
|
I've just learned the: composer updatedoes not invoke plugin installation, while composer installdoes :) |
This was referenced Apr 24, 2021
TomasVotruba
added a commit
that referenced
this pull request
Jul 22, 2024
rectorphp/rector-src@e4c27be [NodeTypeResolver] Clean up re-fill scope on PHPStanNodeScopeResolver on variable variable (#6174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using dev-main for the packages here. Maybe we should create new releases here.