Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AssertEqualsToSameRector #5800

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Conversation

Bl00D4NGEL
Copy link
Contributor

Requested failing fixtures for #5799

@TomasVotruba
Copy link
Member

Thank you. Could you try to fix it?

@Bl00D4NGEL
Copy link
Contributor Author

I'll give it a shot once I get off work later on today - will report back :)

@Bl00D4NGEL
Copy link
Contributor Author

Hey @TomasVotruba
I think I've got a fix ready but it seems other tests are failing that I haven't touched. I'm not sure where these failing tests come from, is it because I started using the nodeTypeResolver inside the rector? I'm happy to fix those failing tests if you or anyone else wants to point me to the right direction.

@TomasVotruba
Copy link
Member

It seems unrelated to your fix

This might help #5808

@TomasVotruba TomasVotruba merged commit 4d69400 into rectorphp:master Mar 9, 2021
@TomasVotruba
Copy link
Member

Looks good, thank you 👍

TomasVotruba added a commit that referenced this pull request Apr 3, 2024
rectorphp/rector-src@0348124 [CodeQuality] Skip Switch_ always returned on ExplicitReturnNullRector (#5800)
TomasVotruba added a commit that referenced this pull request Apr 3, 2024
rectorphp/rector-src@0348124 [CodeQuality] Skip Switch_ always returned on ExplicitReturnNullRector (#5800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants