-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeDeclaration] Add AddParamTypeFromCallersRector #5782
Conversation
b067afb
to
13f6191
Compare
c21072e
to
13f6191
Compare
ce996e2
to
8e56f96
Compare
Wouldnt it make sense to reduce this rector (optional?) to only process private methods? that way the public api of the classes won‘t get touched and therefore the transformation can be done easily |
For private projects it does not make sense. |
My comment was more regarding private vs public visibility of methods, rather then projects |
Understood, I was reacting to that. Public and private methods are the same in scope of private project. Only current code base is using them, so all passed types are known. In matter of open-source project, where input data are missing, it's valid point. |
rectorphp/rector-src@93e0259 [automated] Apply Coding Standard (#5782)
No description provided.