Add RemoveFuncCallArgRector, ClearReturnNewByReferenceRector, RemoveIniGetSetFuncCallRector, ReplaceHttpServerVarsByServerRector

config/set/php/php52.yaml

@@ -1,3 +1,8 @@
 services:
     Rector\Php52\Rector\Property\VarToPublicPropertyRector: null
     Rector\Php52\Rector\Switch_\ContinueToBreakInSwitchRector: null
+
+    # see https://www.php.net/manual/en/function.ldap-first-attribute.php
+    Rector\Core\Rector\FuncCall\RemoveFuncCallArgRector:
+        $argumentPositionByFunctionName:
+            ldap_first_attribute: [2]

docs/rector_rules_overview.md

@@ -1,4 +1,4 @@
-# All 495 Rectors Overview
+# All 499 Rectors Overview
 
 - [Projects](#projects)
 - [General](#general)
@@ -38,7 +38,7 @@
 - [Performance](#performance) (1)
 - [Phalcon](#phalcon) (4)
 - [Php52](#php52) (2)
-- [Php53](#php53) (2)
+- [Php53](#php53) (4)
 - [Php54](#php54) (2)
 - [Php55](#php55) (2)
 - [Php56](#php56) (2)
@@ -6632,6 +6632,20 @@ Remove unused private method
 
 ## Php53
 
+### `ClearReturnNewByReferenceRector`
+
+- class: [`Rector\Php53\Rector\Assign\ClearReturnNewByReferenceRector`](/../master/rules/php53/src/Rector/Assign/ClearReturnNewByReferenceRector.php)
+- [test fixtures](/../master/rules/php53/tests/Rector/Assign/ClearReturnNewByReferenceRector/Fixture)
+
+Remove reference from "$assign = &new Value;"
+
+```diff
+-$assign = &new Value;
++$assign = new Value;
+```
+
+<br>
+
 ### `DirNameFileConstantToDirConstantRector`
 
 - class: [`Rector\Php53\Rector\FuncCall\DirNameFileConstantToDirConstantRector`](/../master/rules/php53/src/Rector/FuncCall/DirNameFileConstantToDirConstantRector.php)
@@ -6652,6 +6666,20 @@ Convert dirname(__FILE__) to __DIR__
 
 <br>
 
+### `ReplaceHttpServerVarsByServerRector`
+
+- class: [`Rector\Php53\Rector\Variable\ReplaceHttpServerVarsByServerRector`](/../master/rules/php53/src/Rector/Variable/ReplaceHttpServerVarsByServerRector.php)
+- [test fixtures](/../master/rules/php53/tests/Rector/Variable/ReplaceHttpServerVarsByServerRector/Fixture)
+
+Rename old $HTTP_* variable names to new replacements
+
+```diff
+-$serverVars = $HTTP_SERVER_VARS;
++$serverVars = $_SERVER;
+```
+
+<br>
+
 ### `TernaryToElvisRector`
 
 - class: [`Rector\Php53\Rector\Ternary\TernaryToElvisRector`](/../master/rules/php53/src/Rector/Ternary/TernaryToElvisRector.php)
@@ -10514,7 +10542,7 @@ Change @return types and type from static analysis to type declarations if not a
 
 ## General
 
-- [Core](#core) (42)
+- [Core](#core) (44)
 
 ## Core
 
@@ -11362,6 +11390,53 @@ services:
 
 <br>
 
+### `RemoveFuncCallArgRector`
+
+- class: [`Rector\Core\Rector\FuncCall\RemoveFuncCallArgRector`](/../master/src/Rector/FuncCall/RemoveFuncCallArgRector.php)
+- [test fixtures](/../master/tests/Rector/FuncCall/RemoveFuncCallArgRector/Fixture)
+
+Remove argument by position by function name
+
+```yaml
+services:
+    Rector\Core\Rector\FuncCall\RemoveFuncCallArgRector:
+        $argumentPositionByFunctionName:
+            remove_last_arg:
+                - 1
+```
+
+↓
+
+```diff
+-remove_last_arg(1, 2);
++remove_last_arg(1);
+```
+
+<br>
+
+### `RemoveIniGetSetFuncCallRector`
+
+- class: [`Rector\Core\Rector\FuncCall\RemoveIniGetSetFuncCallRector`](/../master/src/Rector/FuncCall/RemoveIniGetSetFuncCallRector.php)
+- [test fixtures](/../master/tests/Rector/FuncCall/RemoveIniGetSetFuncCallRector/Fixture)
+
+Remove ini_get by configuration
+
+```yaml
+services:
+    Rector\Core\Rector\FuncCall\RemoveIniGetSetFuncCallRector:
+        $keysToRemove:
+            - y2k_compliance
+```
+
+↓
+
+```diff
+-ini_get('y2k_compliance');
+-ini_set('y2k_compliance', 1);
+```
+
+<br>
+
 ### `RemoveInterfacesRector`
 
 - class: [`Rector\Core\Rector\Interface_\RemoveInterfacesRector`](/../master/src/Rector/Interface_/RemoveInterfacesRector.php)

rules/php53/src/Rector/Assign/ClearReturnNewByReferenceRector.php

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php53\Rector\Assign;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\Assign;
+use PhpParser\Node\Expr\AssignRef;
+use PhpParser\Node\Expr\New_;
+use Rector\Core\Rector\AbstractRector;
+use Rector\Core\RectorDefinition\CodeSample;
+use Rector\Core\RectorDefinition\RectorDefinition;
+
+/**
+ * @sponsor Thanks https://twitter.com/afilina for sponsoring this rule
+
+ * @see https://3v4l.org/UJN6H
+ * @see \Rector\Php53\Rector\Assign\ClearReturnNewByReferenceRector
+ */
+final class ClearReturnNewByReferenceRector extends AbstractRector
+{
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition('Remove reference from "$assign = &new Value;"', [
+            new CodeSample(
+                <<<'CODE_SAMPLE'
+$assign = &new Value;
+CODE_SAMPLE
+                ,
+                <<<'CODE_SAMPLE'
+$assign = new Value;
+CODE_SAMPLE
+            ), ]);
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [AssignRef::class];
+    }
+
+    /**
+     * @param AssignRef $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $node->expr instanceof New_) {
+            return null;
+        }
+
+        return new Assign($node->var, $node->expr);
+    }
+}

rules/php53/src/Rector/Variable/ReplaceHttpServerVarsByServerRector.php

@@ -0,0 +1,62 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php53\Rector\Variable;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\Variable;
+use Rector\Core\Rector\AbstractRector;
+use Rector\Core\RectorDefinition\CodeSample;
+use Rector\Core\RectorDefinition\RectorDefinition;
+
+/**
+ * @sponsor Thanks https://twitter.com/afilina for sponsoring this rule
+ *
+ * @see \Rector\Php53\Tests\Rector\Variable\ReplaceHttpServerVarsByServerRector\ReplaceHttpServerVarsByServerRectorTest
+ * @see https://blog.tigertech.net/posts/php-5-3-http-server-vars/
+ */
+final class ReplaceHttpServerVarsByServerRector extends AbstractRector
+{
+    /**
+     * @var string[]
+     */
+    private const VARIABLE_RENAME_MAP = [
+        'HTTP_SERVER_VARS' => '_SERVER',
+        'HTTP_GET_VARS' => '_GET',
+        'HTTP_POST_VARS' => '_POST',
+        'HTTP_POST_FILES' => '_FILES',
+        'HTTP_SESSION_VARS' => '_SESSION',
+        'HTTP_ENV_VARS' => '_ENV',
+        'HTTP_COOKIE_VARS' => '_COOKIE',
+    ];
+
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition('Rename old $HTTP_* variable names to new replacements', [
+            new CodeSample('$serverVars = $HTTP_SERVER_VARS;', '$serverVars = $_SERVER;'),
+        ]);
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [Variable::class];
+    }
+
+    /**
+     * @param Variable $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        foreach (self::VARIABLE_RENAME_MAP as $oldName => $newName) {
+            if (! $this->isName($node, $oldName)) {
+                continue;
+            }
+
+            $node->name = $newName;
+            return $node;
+        }
+
+        return null;
+    }
+}

rules/php53/tests/Rector/Assign/ClearReturnNewByReferenceRector/ClearReturnNewByReferenceRectorTest.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php53\Tests\Rector\Assign\ClearReturnNewByReferenceRector;
+
+use Iterator;
+use Rector\Core\Testing\PHPUnit\AbstractRectorTestCase;
+use Rector\Php53\Rector\Assign\ClearReturnNewByReferenceRector;
+use SplFileInfo;
+
+final class ClearReturnNewByReferenceRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideDataForTest()
+     */
+    public function test(string $file): void
+    {
+        $this->doTestFileWithoutAutoload($file);
+    }
+
+    /**
+     * @return Iterator<SplFileInfo>
+     */
+    public function provideDataForTest(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    protected function getRectorClass(): string
+    {
+        return ClearReturnNewByReferenceRector::class;
+    }
+}

rules/php53/tests/Rector/Assign/ClearReturnNewByReferenceRector/Fixture/fixture.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+$instance = &new Foo();
+
+?>
+-----
+<?php
+
+$instance = new Foo();
+
+?>

rules/php53/tests/Rector/Variable/ReplaceHttpServerVarsByServerRector/Fixture/fixture.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Php53\Tests\Rector\Variable\ReplaceHttpServerVarsByServerRector\Fixture;
+
+class SomeClass
+{
+    public function run()
+    {
+        $tmp = $HTTP_SERVER_VARS[$var];
+        parse_str($HTTP_SERVER_VARS["QUERY_STRING"]);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Php53\Tests\Rector\Variable\ReplaceHttpServerVarsByServerRector\Fixture;
+
+class SomeClass
+{
+    public function run()
+    {
+        $tmp = $_SERVER[$var];
+        parse_str($_SERVER["QUERY_STRING"]);
+    }
+}
+
+?>

rules/php53/tests/Rector/Variable/ReplaceHttpServerVarsByServerRector/ReplaceHttpServerVarsByServerRectorTest.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php53\Tests\Rector\Variable\ReplaceHttpServerVarsByServerRector;
+
+use Iterator;
+use Rector\Core\Testing\PHPUnit\AbstractRectorTestCase;
+use Rector\Php53\Rector\Variable\ReplaceHttpServerVarsByServerRector;
+use SplFileInfo;
+
+final class ReplaceHttpServerVarsByServerRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideDataForTest()
+     */
+    public function test(string $file): void
+    {
+        $this->doTestFile($file);
+    }
+
+    /**
+     * @return Iterator<SplFileInfo>
+     */
+    public function provideDataForTest(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixtures');
+    }
+
+    protected function getRectorClass(): string
+    {
+        return ReplaceHttpServerVarsByServerRector::class;
+    }
+}