Future-proof ScopeFactory #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
scope-factory
branch
3 times, most recently
from
452c4be to
5d6e3ed
Compare
ondrejmirtes
force-pushed
the
scope-factory
branch
from
5d6e3ed to
67cd31f
Compare
|
I see, thank you Ondra. |
TomasVotruba
added a commit
that referenced
this pull request
Mar 4, 2023
rectorphp/rector-src@ed16cab [Php80] Add typed property Closure support on ClassPropertyAssignToConstructorPromotionRector (#3453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As MutatingScope constructor can change often and is not covered by backwards compatibility promise, this is a much better way to construct it. As you can notice, it's just a bunch of code deleted as you can simply call
$this->phpStanScopeFactory->create()for the same effect.Thanks.