Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resolving for private properties of annotation object #3285

Merged
merged 6 commits into from
Apr 30, 2020
Merged

Add resolving for private properties of annotation object #3285

merged 6 commits into from
Apr 30, 2020

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Apr 30, 2020 •
edited
Loading

@TomasVotruba TomasVotruba mentioned this pull request Apr 30, 2020
Merged
@TomasVotruba TomasVotruba force-pushed the tag-value-node-5 branch 2 times, most recently from d3b0d13 to 28b54a5 Compare April 30, 2020 14:40
@stephanvierkant
Copy link
Contributor

Have you looked at Symfony's PropertyAccess Component?

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Apr 30, 2020 •
edited
Loading

Yes. It just needed reflection, so I picked this https://ocramius.github.io/blog/fast-php-object-to-array-conversion/

There is some weird bug with class reference replacing only in @route :/ not sure why.

@TomasVotruba TomasVotruba changed the title make route fail Add resolving for private properties of annotation object Apr 30, 2020
@TomasVotruba
Copy link
Member Author

TomasVotruba commented Apr 30, 2020 •
edited
Loading

Apperently you cannot set value to private property :D


It's ready to merge.
Do you fancy code review this PR?

@TomasVotruba TomasVotruba merged commit 6fa4e66 into master Apr 30, 2020
@TomasVotruba
Copy link
Member Author

Merging so you can test it out in the wild.

@TomasVotruba TomasVotruba deleted the tag-value-node-5 branch April 30, 2020 15:20
TomasVotruba added a commit that referenced this pull request Jan 14, 2023
@TomasVotruba
Updated Rector to commit 4b6a55998d37cb76336ca512e3f853b8193ddd64
6064d3f 
rectorphp/rector-src@4b6a559 Clean up mix HTML+PHP first stmt check (#3285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @stephanvierkant