Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests for Rector with Drupal #2891

Closed
wants to merge 18 commits into from
Closed

Adding tests for Rector with Drupal #2891

wants to merge 18 commits into from

Conversation

shaal
Copy link
Contributor

@shaal shaal commented Feb 19, 2020

Follow up on #2879

@shaal shaal requested a review from TomasVotruba February 19, 2020 20:04
@shaal shaal requested a review from TomasVotruba February 20, 2020 14:27
@TomasVotruba
Copy link
Member

The path seems wrong:

image

@shaal
Copy link
Contributor Author

shaal commented Feb 26, 2020

@TomasVotruba
In this test, Rector 0.6.13 was running as it should with no issues.
but the test shows as 'fail'.

Can you help me understand what's wrong ?

 [WARNING] 1 nodes were removed                                                 

 [OK] Rector is done! 1 file would have changed (dry-run).                      

 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
##[error]Process completed with exit code 1.

@TomasVotruba
Copy link
Member

TomasVotruba commented Feb 29, 2020 •
edited
Loading

Closing as duplicated of #2891 that is fixed now

#2879 solved as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaal @TomasVotruba