Add PHPStanAttributeTypeSyncer

[TomasVotruba]

Closes #2647

Related Changes

• bump PHPStan to 0.12.5, break with number type resolution in d488d40

[TomasVotruba]

@gnutix This rather meta-utility, to generate AttributeAware nodes from PHPStan nodes. That way we'd know about new PHPStan nodes much faster then reported in the issues.

I'd like to know your feedback.

[gnutix]

That looks awesome! I was wondering how many more types I would discover and add in PRs like these. 😄

[TomasVotruba]

Well, I think that 0 :D should be automated by Github Actions Cron

[gnutix]

Just went through the code quickly ; I didn't read the logic itself nor tested the feature, just added some general comments about code style.

Is there more specific testing you'd like me to do as part of the review ?

Would this PR fix #2614 too ?

[TomasVotruba]

Thank you for review.

#2614 is unrelated to this. This only creates Attribute aware mirror nodes for PhpDocParser nodes. Basically what PhpParser has for format preserving.

The #2614 is about new node, that needs to be converted by static mapper.
There could be used similar collector approach too - wanna try to refactor it?

[gnutix]

I will have very busy upcoming weeks, don't have much mental space to dig into these Rector/PhpStan/PhpParser layers of types (and frankly, its seriously missing documentation on these classes with complicated names - I can't understand the concepts behind it just looking at the code).

But I could yet do another PR to fix #2614... That would be fast and easy.

[TomasVotruba]

I will have very busy upcoming weeks, don't have much mental space to dig into these Rector/PhpStan/PhpParser layers of types

I think it takes time to understand AST and related mechanism. Don't rush on yourself. It took me 1-2 years to get from tokens into state, where the printed content looked as I needed.

But I could yet do another PR to fix #2614... That would be fast and easy.

👍