Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Symfony 4.4/5 and PHP 7.2+ #2344

Merged
merged 4 commits into from
Nov 23, 2019
Merged

Bump to Symfony 4.4/5 and PHP 7.2+ #2344

merged 4 commits into from
Nov 23, 2019

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Nov 22, 2019 •
edited
Loading

Related Changes

  • bump to Symplify 7

@TomasVotruba TomasVotruba changed the title Bump to Symfony 4.4/5 Bump to Symfony 4.4/5 and PHP 7.2+ Nov 23, 2019
TomasVotruba
TomasVotruba commented Nov 23, 2019
View reviewed changes
ecs.yaml
@@ -51,6 +51,7 @@ parameters:
skip:
# rather useless
Symplify\CodingStandard\Sniffs\DependencyInjection\NoClassInstantiationSniff: ~
PhpCsFixer\Fixer\Import\GlobalNamespaceImportFixer: ~
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixer breaks everything, nay

@TomasVotruba TomasVotruba merged commit 45a6df7 into master Nov 23, 2019
@TomasVotruba TomasVotruba deleted the symfony-5 branch November 23, 2019 18:03
TomasVotruba added a commit that referenced this pull request May 22, 2022
@TomasVotruba
Updated Rector to commit a59e9ce
cb9cf8d 
rectorphp/rector-src@a59e9ce Fix return type of FileInfoParser::parseFileInfoToNodesAndDecorate (#2344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @staabm