ImportFullyQualifiedNamesRector : add a failing test about modified annotations that shouldn't be

[gnutix]

I've finally been able to add ImportFullyQualifiedNamesRector to our project thanks to the new "skip root namespace" option. And I've noticed 3 nasty bugs in there (losing @ORM\Table argument, de-doubling of @ORM\InheritanceType argument, removing @Route arguments).

So I've added a test case with all these annotations, which resulted in :

1) Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\ImportFullyQualifiedNamesRectorTest::test with data set #22 ('/home/gnutix/dev/oss/rectorph...hp.inc')
Caused by /home/gnutix/dev/oss/rectorphp/rector/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/should_keep_all_doc_blocks_annotations_parameters.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 use Symfony\Component\Routing\Annotation\Route;
 
 /**
- * @ORM\Table("Table_Name")
- * @ORM\Entity()
- * @ORM\InheritanceType("SINGLE_TABLE")
+ * @ORM\Table
+ * @ORM\Entity
+ * @ORM\InheritanceType("SINGLE_TABLE")("SINGLE_TABLE")
  */
 class ShouldKeepAllDocBlocksAnnotationsParameters
 {
     /**
-     * @Route(
-     *     "/{arg1}/{arg2}",
-     *     defaults={"arg1"=null, "arg2"=""},
-     *     requirements={"arg1"="\d+", "arg2"=".*"}
-     * )
+     * @Route    (     path="/{arg1}/{arg2}" )
      */
     public function nothing(): void
     {

/home/gnutix/dev/oss/rectorphp/rector/src/Testing/PHPUnit/AbstractRectorTestCase.php:182
/home/gnutix/dev/oss/rectorphp/rector/src/Testing/PHPUnit/AbstractRectorTestCase.php:136
/home/gnutix/dev/oss/rectorphp/rector/packages/CodingStyle/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/ImportFullyQualifiedNamesRectorTest.php:17

[gnutix]

Seems like there's still a Travis build that works :

PHP: 7.1
COMPOSER_FLAGS="--prefer-lowest"

So probably that this has something to do with Rector's composer dependencies version.

[TomasVotruba]

I recommend checking different versions of:

• doctrine/annotations
• phpstan/phpdoc-parser

[TomasVotruba]

It seems tests are skipped on PHP 7.1 for some reason

Now it fails thanks to --testsuite main option