Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for various annotation formats #2048

Merged
merged 3 commits into from
Sep 27, 2019

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Sep 27, 2019

People write annotation in various format, that are still valid in PHP thanks to case sensitivity and use statements. We should add such support here as well

Before Only

use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Id
 */ 

After

use Doctrine\ORM\Mapping as ORM;
use Doctrine\ORM\Mapping\Id;

/**
 * @ORM\Id
 * @Orm\id
 * @Id 
 */

@TomasVotruba TomasVotruba changed the title Add support for various annotation formats [WIP] Add support for various annotation formats Sep 27, 2019
@TomasVotruba TomasVotruba force-pushed the allow-variosu-doc-format branch from 1485e7b to e6a76ae Compare September 27, 2019 19:45
@TomasVotruba TomasVotruba force-pushed the allow-variosu-doc-format branch from e6a76ae to c626a50 Compare September 27, 2019 19:45
@TomasVotruba TomasVotruba force-pushed the allow-variosu-doc-format branch from 141e784 to a1e9a52 Compare September 27, 2019 20:02
@TomasVotruba TomasVotruba changed the title [WIP] Add support for various annotation formats Add support for various annotation formats Sep 27, 2019
@TomasVotruba TomasVotruba merged commit 641ede1 into master Sep 27, 2019
@TomasVotruba TomasVotruba deleted the allow-variosu-doc-format branch September 27, 2019 20:16
TomasVotruba added a commit that referenced this pull request Apr 10, 2022
rectorphp/rector-src@60f1dad Merge FollowRequireByDirRector to almost identical AbsolutizeRequireAndIncludePathRector (#2048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant