[PSR4] Improve MultipleClassFileToPsr4ClassesRector output #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
psr4-output
branch
4 times, most recently
from
f381c45 to
914a4bc
Compare
|
Awesome! 👍 Just a quick feedback, imho yellow background for warning what files will be removed would be better, that big red block is invoking in me there is something wrong and has to be fixed. |
|
Agreed :) comming in Symfonx 4.3 this month |
TomasVotruba
added a commit
that referenced
this pull request
Dec 9, 2021
rectorphp/rector-src@bd75e1a [Scoped] Skip symfony console Event and EventListener and exclude in parallel-lint (#1439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1360
Before
[OK] Rector is done! 0 changed filesAfter
--dry-runAfter without
--dry-run