-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to rename classes and it's namespace #1382
Conversation
4be7840
to
c78fbc3
Compare
@TomasVotruba i have covered all scenarios i could think about with tests, they are working, rebased on master and squashed. Though tests could cover refactoring with annotations and editing annotations return values/type hints. Feel free to update ;-) I will be very happy for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added review, great work 👍
tests/Rector/Class_/RenameClassRector/RenameClassRectorTest.php
Outdated
Show resolved
Hide resolved
tests/Rector/Class_/RenameClassRector/RenameClassRectorTest.php
Outdated
Show resolved
Hide resolved
a3e8912
to
0e70233
Compare
Ready for re-review :-). Though i had tests failing locally, if i checked out master, same tests were failing as well, so i think these are not caused by this PR:
|
Tests should pass, Travis is green on master |
Thx for tip, this fixed 1 error, still 2 are there:
But since travis passes even here, i will ignore it, might be something with my local environment. |
15d1f2d
to
f27d50e
Compare
I'm suspecting Mac slashes in |
I've added one commit. You'll have to pull it before squasing. Just squash it and I'll merge it 👍 |
565d056
to
9958a44
Compare
Great job, thanks! |
rectorphp/rector-src@26166bd [Rectify] [Php81] Enable Rectify for New in Initialization only (#1382)
Closes #1373