Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup tests by 90 % from 41 secs to 4 #1354

Merged
merged 6 commits into from
Apr 28, 2019
Merged

Speedup tests by 90 % from 41 secs to 4 #1354

merged 6 commits into from
Apr 28, 2019

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Apr 26, 2019

Closes #1332

Before - 41 secs

image

After - 4 secs

after

@TomasVotruba TomasVotruba force-pushed the speedup-test branch 2 times, most recently from 9c77707 to 3c2ff06 Compare April 28, 2019 21:18
@TomasVotruba TomasVotruba changed the title [WIP] Make tests create container just once, only change active Rector class Speedup tests by 90 % from 41 secs to 4 Apr 28, 2019
@TomasVotruba TomasVotruba force-pushed the speedup-test branch 2 times, most recently from aaa0dca to 714f25a Compare April 28, 2019 21:34
@TomasVotruba TomasVotruba force-pushed the speedup-test branch 2 times, most recently from feb13ea to be7b755 Compare April 28, 2019 23:03
@TomasVotruba TomasVotruba merged commit db36e50 into master Apr 28, 2019
@TomasVotruba TomasVotruba mentioned this pull request Apr 29, 2019
@TomasVotruba TomasVotruba deleted the speedup-test branch April 29, 2019 09:05
TomasVotruba added a commit that referenced this pull request Nov 30, 2021
rectorphp/rector-src@4287ca3 [Php81] Skip no type property on ReadOnlyPropertyRector (#1354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests] Speed up, don't create new container for every Rector class
1 participant