Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOLID] Add PrivatizeLocalClassConstantRector #1304

Merged
merged 2 commits into from
Apr 12, 2019
Merged

[SOLID] Add PrivatizeLocalClassConstantRector #1304

merged 2 commits into from
Apr 12, 2019

Conversation

TomasVotruba
Copy link
Member

Ref #151

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Apr 10, 2019 •
edited
Loading

  • Add PHP 7.1 level min

Test cases

  • ob 2 parents
  • interfaces constants
  • use in parent and external claas

@TomasVotruba TomasVotruba mentioned this pull request Apr 10, 2019
Closed
@TomasVotruba TomasVotruba changed the title [WIP] [SOLID] Add PrivatizeLocalClassConstantRector [SOLID] Add PrivatizeLocalClassConstantRector Apr 10, 2019
@TomasVotruba TomasVotruba merged commit a334d9d into master Apr 12, 2019
@TomasVotruba TomasVotruba deleted the solid-privatize branch April 12, 2019 23:52
@mxr576
Copy link
Contributor

mxr576 commented Apr 22, 2019

@TomasVotruba Have you forgotten to add the new PrivatizeLocalClassConstantRector to the SOLID config?

https://github.com/rectorphp/rector/blob/v0.4.11/config/level/solid/solid.yaml

@TomasVotruba
Copy link
Member Author

It seem like. Care for PR?

@mxr576
Copy link
Contributor

mxr576 commented Apr 22, 2019

Thanks for the confirmation. Sure, I'll create one tomorrow with the fix.

mxr576 added a commit to mxr576/rector that referenced this pull request Apr 23, 2019
@mxr576
Add PrivatizeLocalClassConstantRector to SOLID
d7f012b 
Original PR: rectorphp#1304
@mxr576 mxr576 mentioned this pull request Apr 23, 2019
Merged
@TomasVotruba TomasVotruba mentioned this pull request Mar 29, 2020
Closed
TomasVotruba added a commit that referenced this pull request Nov 25, 2021
@TomasVotruba
Updated Rector to commit 50a78a6
215fcca 
rectorphp/rector-src@50a78a6 [Downgrade PHP 7.0] Add DowngradeClosureCallRector (#1304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @mxr576