Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check minimum php version before running IsCountableRector and TernaryToSpaceshipRector #1192

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

endelwar
Copy link
Contributor

fix #1191

@TomasVotruba
Copy link
Member

Great job, thank you 👍

@TomasVotruba TomasVotruba merged commit b12cf38 into rectorphp:master Mar 12, 2019
@endelwar endelwar deleted the check-php-version branch March 12, 2019 17:37
TomasVotruba added a commit that referenced this pull request Nov 8, 2021
rectorphp/rector-src@4815cd9 [DowngradePhp81/80] Skip combine check with is_resource and instanceof Object (#1192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsCountableRector is executed even if php_version_features is < 7.3
2 participants