Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect behavior of MakeEntityDateTimePropertyDateTimeInterfaceRector #8446

Closed
mvhirsch opened this issue Jan 31, 2024 · 3 comments · Fixed by rectorphp/rector-doctrine#256
Closed

Incorrect behavior of MakeEntityDateTimePropertyDateTimeInterfaceRector #8446

mvhirsch opened this issue Jan 31, 2024 · 3 comments · Fixed by rectorphp/rector-doctrine#256
Labels
bug

Comments

@mvhirsch
Copy link

Bug Report

Subject Details
Rector version 0.19.2
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/c1de8a19-85ed-440c-8d10-039dae4df9b9

<?php

/**
 * @final
 */
class VideoCreator
{
    /** @var \DateTime */
    protected $date;
}

Responsible rules

  • MakeEntityDateTimePropertyDateTimeInterfaceRector

Expected Behavior

Rector should skip this service, as it is not a declared Doctrine Entity.
@mvhirsch mvhirsch added the bug label Jan 31, 2024
@TomasVotruba
Copy link
Member

Thank you for reporting. I'm looking into this 👍

@TomasVotruba TomasVotruba mentioned this issue Jan 31, 2024
Merged
@TomasVotruba
Copy link
Member

Fixed in #8446

@mvhirsch
Copy link
Author

mvhirsch commented Feb 1, 2024

Thank you very much!

Fixed in rectorphp/rector-doctrine#256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip date time unless entity rectorphp/rector-doctrine
2 participants
@mvhirsch @TomasVotruba