Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor that would check order of called private methods and reorder them if needed #4

Closed
TomasVotruba opened this issue Jul 25, 2017 · 1 comment
Closed

Refactor that would check order of called private methods and reorder them if needed #4

TomasVotruba opened this issue Jul 25, 2017 · 1 comment

Comments

@TomasVotruba
Copy link
Member 

private function getThis()
{
}

// this one should be above, because reading code from top to bottom makes is easier to understand
private function getThat()
{
    return $this->getThis();
}
@TomasVotruba
Copy link
Member Author

Too imba

@hernst42 hernst42 mentioned this issue Oct 14, 2019
Closed
@yuzuofu yuzuofu mentioned this issue Feb 6, 2020
Closed
TomasVotruba added a commit that referenced this issue Sep 8, 2020
@TomasVotruba
# This is a combination of 4 commits.
9131252 
# This is the 1st commit message:

add monorepo split for value objects function

# The commit message #2 will be skipped:

# fixup! add monorepo split for value objects function

# The commit message #3 will be skipped:

# fixup! fixup! add monorepo split for value objects function

# The commit message #4 will be skipped:

# fixup! fixup! fixup! add monorepo split for value objects function
TomasVotruba added a commit that referenced this issue Mar 7, 2021
@TomasVotruba
[TypeDeclaration] Improve param by caller type #4 (#5793)
8d79b4f 
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
TomasVotruba added a commit that referenced this issue May 10, 2021
@TomasVotruba
Updated Rector to commit f451b0b
cdc3b7a 
f451b0b [PHP 8.0] Bump to promoted properties (#4)
sabbelasichon pushed a commit to sabbelasichon/rector that referenced this issue May 11, 2021
@TomasVotruba
[PHP 8.0] Bump to promoted properties (rectorphp#4)
f451b0b
@canvural canvural mentioned this issue Jul 30, 2021
Closed
@canvural canvural mentioned this issue Nov 9, 2021
Closed
TomasVotruba added a commit that referenced this issue Nov 28, 2021
@TomasVotruba
Updated Rector to commit 185ee1b
11660d5 
rectorphp/rector-src@185ee1b [DX] Add strict PHPStan rules - step #4 (#1333)
@Tobion Tobion mentioned this issue Dec 15, 2021
Closed
@sergey-telpuk sergey-telpuk mentioned this issue Dec 31, 2021
Closed
@alejomoreira alejomoreira mentioned this issue Aug 15, 2022
Closed
@dvenckusvh dvenckusvh mentioned this issue Jun 9, 2023
Closed
@7thstorm 7thstorm mentioned this issue Jun 13, 2023
Closed
TomasVotruba added a commit that referenced this issue Jul 20, 2023
@TomasVotruba
Updated Rector to commit ef6aa9efa5392f2b799d0c5cb38205ee9c119a75
03ebf96 
rectorphp/rector-src@ef6aa9e Make use of toPhpDocNode() - take #4 (#4559)
TomasVotruba added a commit that referenced this issue Aug 6, 2023
@TomasVotruba
Updated Rector to commit 3a048f6f6a6614a46eea06abffb7324b15fdc9dc
b4217dc 
rectorphp/rector-src@3a048f6 [DX] Make use of Laravel container in few tests - step #4 (#4681)
@alexander-schranz alexander-schranz mentioned this issue Aug 16, 2023
Closed
@gillboysimran gillboysimran mentioned this issue Sep 27, 2023
Closed
@Metztli Metztli mentioned this issue Nov 17, 2023
Closed
@sanscript sanscript mentioned this issue Dec 12, 2023
Closed
@LDSTATXPERT LDSTATXPERT mentioned this issue Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomasVotruba