Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOLID] Define constants instead of literals #3303

Closed
TomasVotruba opened this issue May 3, 2020 · 0 comments · Fixed by #3325
Closed

[SOLID] Define constants instead of literals #3303

TomasVotruba opened this issue May 3, 2020 · 0 comments · Fixed by #3325

Comments

@TomasVotruba
Copy link
Member

TomasVotruba commented May 3, 2020 •
edited
Loading

Reported by Sonar:

image
@TomasVotruba TomasVotruba changed the title [SOLID] Define constnat instead of literals [SOLID] Define constants instead of literals May 3, 2020
@TomasVotruba TomasVotruba mentioned this issue May 6, 2020
Merged
TomasVotruba added a commit that referenced this issue Jan 24, 2023
@TomasVotruba
Updated Rector to commit 2c353227e499072689cbb22d83b3483b3015025f
be2e22e 
rectorphp/rector-src@2c35322 [Printer] Handle Add Node after Nop statement inlineHTML (#3303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SOLID] Add RepeatedLiteralToClassConstantRector rectorphp/rector
1 participant
@TomasVotruba