Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Add "big" note about why there are both FCQN in inject & imports #1683

Closed
stloyd opened this issue Jul 4, 2019 · 1 comment · Fixed by #1713
Closed

[README] Add "big" note about why there are both FCQN in inject & imports #1683

stloyd opened this issue Jul 4, 2019 · 1 comment · Fixed by #1713

Comments

@stloyd
Copy link
Contributor

stloyd commented Jul 4, 2019

As per comment: #1564 (comment)

The best ways to solve this is using coding standard to handle your imports.
Using FQN by default is to allow them import or keep FQN - some people prefer first, some second. And it's harder to FQNize than import in coding standard rules.

tl;dr; AST sucks in coding standard, and always will. It doesn't make sense to rewrite EasyCodingStandard, PHP CS Fixer or CodeSnffier. Just use it.

See this comment for deeper answer: #1456 (comment)

I recommend using option --with-style: https://github.com/rectorphp/rector#how-to-apply-coding-standards

This IMHO should be hardly noted in README file, so there is clear point why it's this way & why it will not be fixed.

@TomasVotruba
Copy link
Member

I'm not the best person to do this, since I suffer author blindness.

Could you send PR so it's understanable for you as a tool user?

TomasVotruba added a commit that referenced this issue Jan 16, 2022
rectorphp/rector-src@72de31e Ensure autoloader is loaded in globally installed Rector (#1683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants