[CodeQuality] Skip collections ForeachToInArrayRector [closes #1533]

rectorphp · Jun 4, 2019 · 9dfb666 · 9dfb666
1 parent d8dbf06
commit 9dfb666
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/packages/CodeQuality/src/Rector/Foreach_/ForeachToInArrayRector.php b/packages/CodeQuality/src/Rector/Foreach_/ForeachToInArrayRector.php
@@ -14,6 +14,7 @@
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
 use PhpParser\Node\Stmt\Return_;
+use PHPStan\Type\ObjectType;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PhpParser\Node\Manipulator\BinaryOpManipulator;
 use Rector\PhpParser\NodeTraverser\CallableNodeTraverser;
@@ -93,6 +94,11 @@ public function refactor(Node $node): ?Node
         $ifCondition = $firstNodeInsideForeach->cond;
         $foreachValueVar = $node->valueVar;
 
+        $foreachValueStaticType = $this->getStaticType($node->expr);
+        if ($foreachValueStaticType instanceof ObjectType) {
+            return null;
+        }
+
         $matchedNodes = $this->matchNodes($ifCondition, $foreachValueVar);
         if ($matchedNodes === null) {
             return null;

diff --git a/...Rector/Fixture/ignore_collections.php.inc → ...ayRector/Fixture/skip_collections.php.inc b/...Rector/Fixture/ignore_collections.php.inc → ...ayRector/Fixture/skip_collections.php.inc
@@ -4,7 +4,7 @@ namespace Rector\CodeQuality\Tests\Rector\Foreach_\ForeachToInArrayRector\Fixtur
 
 use Rector\CodeQuality\Tests\Rector\Foreach_\ForeachToInArrayRector\Source\Collection;
 
-final class IgnoreCollections
+final class SkipCollections
 {
     public function foreachToInArray(): bool
     {

diff --git a/...s/CodeQuality/tests/Rector/Foreach_/ForeachToInArrayRector/ForeachToInArrayRectorTest.php b/...s/CodeQuality/tests/Rector/Foreach_/ForeachToInArrayRector/ForeachToInArrayRectorTest.php
@@ -14,7 +14,7 @@ public function test(): void
             __DIR__ . '/Fixture/fixture2.php.inc',
             __DIR__ . '/Fixture/fixture3.php.inc',
             __DIR__ . '/Fixture/fixture4.php.inc',
-            __DIR__ . '/Fixture/ignore_collections.php.inc',
+            __DIR__ . '/Fixture/skip_collections.php.inc',
         ]);
     }