[Phpunit] Prevent MethodCall instances of being processed (#5798)

Co-authored-by: Dominik Peters <d.peters@billiger-mietwagen.de>
rectorphp · Mar 8, 2021 · 5f70de5 · 5f70de5
1 parent 896ca73
commit 5f70de5
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 3 deletions.
diff --git a/rules/phpunit/src/Rector/MethodCall/AssertFalseStrposToContainsRector.php b/rules/phpunit/src/Rector/MethodCall/AssertFalseStrposToContainsRector.php
@@ -79,7 +79,7 @@ public function refactor(Node $node): ?Node
         }
 
         $firstArgumentValue = $node->args[0]->value;
-        if ($firstArgumentValue instanceof StaticCall) {
+        if ($firstArgumentValue instanceof StaticCall || $firstArgumentValue instanceof MethodCall) {
             return null;
         }
         if (! $this->isNames($firstArgumentValue, ['strpos', 'stripos'])) {

diff --git a/rules/phpunit/src/Rector/MethodCall/AssertPropertyExistsRector.php b/rules/phpunit/src/Rector/MethodCall/AssertPropertyExistsRector.php
@@ -89,7 +89,7 @@ public function refactor(Node $node): ?Node
         }
 
         $firstArgumentValue = $node->args[0]->value;
-        if ($firstArgumentValue instanceof StaticCall) {
+        if ($firstArgumentValue instanceof StaticCall || $firstArgumentValue instanceof MethodCall) {
             return null;
         }
         if (! $this->isName($firstArgumentValue, 'property_exists')) {

diff --git a/rules/phpunit/src/Rector/MethodCall/AssertTrueFalseToSpecificMethodRector.php b/rules/phpunit/src/Rector/MethodCall/AssertTrueFalseToSpecificMethodRector.php
@@ -89,7 +89,7 @@ public function refactor(Node $node): ?Node
         }
 
         $firstArgumentValue = $node->args[0]->value;
-        if ($firstArgumentValue instanceof StaticCall) {
+        if ($firstArgumentValue instanceof StaticCall || $firstArgumentValue instanceof MethodCall) {
             return null;
         }
 

diff --git a/...ests/Rector/MethodCall/AssertFalseStrposToContainsRector/Fixture/skip_method_call.php.inc b/...ests/Rector/MethodCall/AssertFalseStrposToContainsRector/Fixture/skip_method_call.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\Rector\MethodCall\AssertFalseStrposToContainsRector\Fixture;
+
+final class SkipMethodCall extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $someObject = new Foo();
+        self::assertFalse($someObject->someMethod());
+    }
+}
diff --git a/...punit/tests/Rector/MethodCall/AssertPropertyExistsRector/Fixture/skip_method_call.php.inc b/...punit/tests/Rector/MethodCall/AssertPropertyExistsRector/Fixture/skip_method_call.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\Rector\MethodCall\AssertPropertyExistsRector\Fixture;
+
+final class SkipMethodCall extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $someObject = new Foo();
+        self::assertFalse($someObject->someMethod());
+    }
+}
diff --git a/.../Rector/MethodCall/AssertTrueFalseToSpecificMethodRector/Fixture/skip_method_call.php.inc b/.../Rector/MethodCall/AssertTrueFalseToSpecificMethodRector/Fixture/skip_method_call.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\Rector\MethodCall\AssertTrueFalseToSpecificMethodRector\Fixture;
+
+final class SkipMethodCall extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $someObject = new Foo();
+        self::assertFalse($someObject->someMethod());
+    }
+}