Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withRootFiles now apply rector for dotfiles too #6592

Merged

Conversation

andrew-demb
Copy link
Contributor

@andrew-demb
Copy link
Contributor Author

Side question: why is there a custom implementation of parsing the .gitignore file in withRootFiles(), but not using the symfony/finder feature?

https://symfony.com/doc/current/components/finder.html#:~:text=%24finder%2D%3E-,ignoreVCSIgnored,-(true)%3B

If the search directory and its subdirectories contain .gitignore files, you can reuse those rules to exclude files and directories from the results with the ignoreVCSIgnored() method:

// excludes files/directories matching the .gitignore patterns
$finder->ignoreVCSIgnored(true);

.phpstorm.meta.php Outdated Show resolved Hide resolved
@andrew-demb andrew-demb force-pushed the with-root-files-apply-for-dotfiles branch from 7deedc1 to 0c6a4cc Compare December 15, 2024 18:10
@TomasVotruba
Copy link
Member

Thank you, let's give this a try 👍

@TomasVotruba TomasVotruba merged commit 967e983 into rectorphp:main Dec 15, 2024
41 checks passed
@andrew-demb andrew-demb deleted the with-root-files-apply-for-dotfiles branch December 15, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withRootFiles() ignores ".php-cs-fixer.dist.php"
2 participants