Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PostRector] Keep first comment before first Use_ if removed on UnusedImportRemovingPostRector #6522

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 29, 2024

First comment can be a license docblock.

Ref https://getrector.com/demo/474af1c4-c629-46d9-9e8c-37cdfb91ac32

this PR fix it.

Fixes rectorphp/rector#8913

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @jorgsowa

@samsonasik samsonasik changed the title [PostRector] Keep first comment before first Use_ on UnusedImportRemovingPostRector [PostRector] Keep first comment before first Use_ if removed on UnusedImportRemovingPostRector Nov 29, 2024
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit dc67365 into main Nov 29, 2024
36 checks passed
@samsonasik samsonasik deleted the keep-first-comment branch November 29, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnusedImport eating comment
1 participant