Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Skip compare nullable object on UseIdenticalOverEqualWithSameTypeRector #6474

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[CodeQuality] Skip compare nullable object on UseIdenticalOverEqualWithSameTypeRector #6474

merged 3 commits into from
Nov 22, 2024

Conversation

samsonasik
Copy link
Member

Fixes rectorphp/rector#8906
Ref equal vs identical on nullable object https://3v4l.org/JDGRQ

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit d49ace3 into main Nov 22, 2024
36 checks passed
@samsonasik samsonasik deleted the skip-compare-nullable-object branch November 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of UseIdenticalOverEqualWithSameTypeRector
2 participants
@samsonasik @actions-user