Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Privatization] Skip with parameter on PrivatizeLocalGetterToPropertyRector #6412

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[Privatization] Skip with parameter on PrivatizeLocalGetterToPropertyRector #6412

merged 2 commits into from
Nov 8, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 8, 2024 •
edited
Loading

Ref https://3v4l.org/sPe0c (work)
Ref https://3v4l.org/Pu2Eb (error)
Ref https://getrector.com/demo/032bff1f-4445-4b88-a090-7d1ed7d29864

that cause error:

Warning: Undefined variable $parameter in /in/Pu2Eb on line 10

Warning: Undefined property: SkipWithParameter::$ in /in/Pu2Eb on line 10

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 1b1807b into main Nov 8, 2024
36 checks passed
@samsonasik samsonasik deleted the skip-with-param branch November 8, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik