Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply AddOverrideAttributeToOverriddenMethodsRector to traits #6367

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jrjohnson
Copy link
Contributor

Apply the Override Attribute to methods inherited from abstract methods in a trait.

Re-opens #6366 with the change restricted to only abstract methods in a trait.

Example of this in action:
https://3v4l.org/qUg3R

Apply the Override Attribute to methods inherited from abstract methods
in a trait.
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@samsonasik samsonasik merged commit 6b72288 into rectorphp:main Oct 9, 2024
36 checks passed
@samsonasik
Copy link
Member

Thank you @jrjohnson

@jrjohnson jrjohnson deleted the override-attribute-in-trait branch October 9, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants