Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php80] Cast string/int for int vs string condition and case condition on ChangeSwitchToMatchRector #6359

Merged
merged 2 commits into from
Oct 6, 2024
Merged

[Php80] Cast string/int for int vs string condition and case condition on ChangeSwitchToMatchRector #6359

merged 2 commits into from
Oct 6, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @namex42 this check type for native php type (not docblock), ensure string vs int comparison is correct.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 748330a into main Oct 6, 2024
36 checks passed
@samsonasik samsonasik deleted the cast-string-int branch October 6, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChangeSwitchToMatchRector should cast subject expression
2 participants
@samsonasik @actions-user