Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php81] Allow used as assign expr on ReadOnlyPropertyRector #6331

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[Php81] Allow used as assign expr on ReadOnlyPropertyRector #6331

merged 2 commits into from
Sep 27, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 27, 2024 •
edited
Loading

Fixes rectorphp/rector#8844

@samsonasik
Copy link
Member Author

implemented 🎉 /cc @tmvpobeda

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready to review.

@TomasVotruba TomasVotruba merged commit e2d9647 into main Sep 27, 2024
36 checks passed
@TomasVotruba
Copy link
Member

Looks good 👍

@TomasVotruba TomasVotruba deleted the allow-used-assign-expr branch September 27, 2024 17:11
@samsonasik samsonasik mentioned this pull request Oct 2, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ReadOnlyPropertyRector
2 participants
@samsonasik @TomasVotruba