Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more assign cases in PropertyFetchAssignManipulator #6192

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

andersonamuller
Copy link
Contributor

@andersonamuller andersonamuller commented Jul 26, 2024

It was suggesting this rector rule in this case:

final class SomeClass
{
    private string $name;

    public function __construct()
    {
        $this->name = __NAMESPACE__;
        $this->name .= __CLASS__;
    }
}

@TomasVotruba
Copy link
Member

Thanks 👍

Could you add test case as well so we avoid regressions?

@andersonamuller
Copy link
Contributor Author

I added a test.

@TomasVotruba TomasVotruba merged commit 0c06da9 into rectorphp:main Jul 28, 2024
34 checks passed
@TomasVotruba
Copy link
Member

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants