Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip phpdoc types in NumericReturnTypeFromStrictReturnsRector #6153

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Skip phpdoc types in NumericReturnTypeFromStrictReturnsRector #6153

merged 1 commit into from
Jul 16, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 16, 2024

No description provided.

@staabm
Copy link
Contributor Author

staabm commented Jul 16, 2024 •
edited
Loading

I can't count how often such kind of regressions happen on rector releases.

maybe it would make sense to run rector-src on some real-world project in CI?
I think we need something to catch such "easy errors" earlier.

@TomasVotruba TomasVotruba merged commit 021085d into rectorphp:main Jul 16, 2024
34 checks passed
@TomasVotruba
Copy link
Member

TomasVotruba commented Jul 16, 2024 •
edited
Loading

Thanks 👍

We could try that. It would have to be fast and just work :)

@staabm staabm deleted the skip-phpdoc branch July 16, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @TomasVotruba