New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php71] Handle not identical to Float for empty string should compare to 0.0 on BinaryOpBetweenNumberAndStringRector #6117

Merged

TomasVotruba merged 2 commits into main from not-identical-float

Jul 5, 2024

Member

samsonasik commented Jul 5, 2024 •

edited

Loading

not identical for (float) 0 vs 0.0 should be false as both are identical.

Ref https://3v4l.org/HE1sb

samsonasik added 2 commits

July 5, 2024 12:37


          [Php71] Handle not identical to Float for empty string should compare…

abfc812

… to 0.0 on BinaryOpBetweenNumberAndStringRector

Fix

c0e5b2e

Member Author

samsonasik commented Jul 5, 2024

All checks have passed 🎉 @TomasVotruba I think it is ready.

TomasVotruba approved these changes

View reviewed changes

TomasVotruba merged commit e63e9a2 into main

33 checks passed

TomasVotruba deleted the not-identical-float branch

July 5, 2024 07:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet