-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e][Printer] Handle crash indentation on AddParamBasedOnParentClassMethodRector #6112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed 🎉 /cc @RuesimOfCode |
All checks have passed 🎉 @TomasVotruba I think it is ready. |
This looks like bug in php-parser itself. If that's true, we should report it first there with a reproducer. |
TomasVotruba
reviewed
Jul 3, 2024
TomasVotruba
force-pushed
the
indentation-crash-error
branch
2 times, most recently
from
July 12, 2024 08:43
0c0980b
to
c71c27f
Compare
rules/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector.php
Outdated
Show resolved
Hide resolved
Ready to go 👍 |
TomasVotruba
force-pushed
the
indentation-crash-error
branch
from
July 12, 2024 08:45
c71c27f
to
c969d42
Compare
I can't approve my own PR, i think this is ready, just probably concern about renaming method bc break :) |
samsonasik
commented
Jul 12, 2024
TomasVotruba
force-pushed
the
indentation-crash-error
branch
from
July 12, 2024 09:28
cdcbd9e
to
52b9aa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8712
Step to reproduce only via e2e test:
without this patch, it will cause error:
For note: I already tried set
origNode = null
on the target rule, but no luck, it only resolvable via printer.