ReturnUnionTypeRector now skips nullable types, to prepare space for new nullable rule as off PHP 7.1+ #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-nullable-returns
branch
from
062625f
to
ef2f75c
Compare
samsonasik
reviewed
Jul 2, 2024
| @@ -26,7 +26,7 @@ namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnUnionTypeRector\ | |||
| final class FalseBoolDocblock | |||
| { | |||
| /** | |||
| * @return array|false some description | |||
| * @return array|bool some description | |||
There was a problem hiding this comment.
new rule to update sub type by docblock seems needed, to ensure not introduce phpstan notice
There was a problem hiding this comment.
Docblock changes are out of our scope since Rector 0.15. This will have to be dealt manualy.
There was a problem hiding this comment.
That will ok for 1 or 2 files, but for many files, imo, that's worth it, I think coding-style or code-quality set will match that
There was a problem hiding this comment.
That's beyond our scope. I'd leave that for manual review or custom set 👍
There was a problem hiding this comment.
Also, this seems rather rare case.
TomasVotruba
changed the title
TomasVotruba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref rectorphp/rector#8707