Add only_direct_assign config for SimplifyUselessVariableRector
#6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good 👍 Could you send a feature as well together? |
|
@ruudk @TomasVotruba I think this should be configurable, eg: |
ruudk
force-pushed
the
SkipMultiConcatString
branch
from
78d3962
to
1e0af59
Compare
ruudk
changed the title
SKIP_CONCAT config for SimplifyUselessVariableRector
|
Great, I just updated the PR with an implementation. Let me know if you prefer other naming or have any feedback. Thanks! |
samsonasik
reviewed
Jun 26, 2024
rules/CodeQuality/Rector/FunctionLike/SimplifyUselessVariableRector.php
Outdated
Show resolved
Hide resolved
When a variable is assigned using concatenation it should not simplify the variable. This looks weird: ```diff $content = 'Hello, '; -$content .= 'World!'; -return $content; +return $content . 'World!'; ``` It would be better to keep the original: ```php $content = 'Hello, '; $content .= 'World!'; return $content; ```
ruudk
force-pushed
the
SkipMultiConcatString
branch
from
1e0af59
to
2669c07
Compare
ruudk
changed the title
SKIP_CONCAT config for SimplifyUselessVariableRectoronly_direct_assign config for SimplifyUselessVariableRector
samsonasik
approved these changes
Jun 26, 2024
|
Thank you @ruudk 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a variable is assigned using concatenation it should not simplify the variable.
This looks weird:
It would be better to keep the original: