Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Remove union with interface on RemoveUselessParamTagRector to make it consistent #5794

Merged
merged 2 commits into from
Apr 3, 2024
Merged

[DeadCode] Remove union with interface on RemoveUselessParamTagRector to make it consistent #5794

merged 2 commits into from
Apr 3, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 3, 2024 •
edited
Loading

@arjenschol after some thinking, union with interface is fine to be removed:

-    /**
-     * @param SomeClass|SomeInterface $someInterface
-     */
    public function run(SomeInterface $someInterface)

which SomeClass implements SomeInterface.

Ref #5684

@samsonasik samsonasik enabled auto-merge (squash) April 3, 2024 07:02
@samsonasik samsonasik merged commit f889e41 into main Apr 3, 2024
41 checks passed
@samsonasik samsonasik deleted the remove-union-with-interface branch April 3, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @actions-user