Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer-dependency-analyser: fix dependency issues #5777

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal commented Mar 27, 2024

Hi, I tested this repository with composer-dependency-analyser and it found some issues.

I tried fixing those, but you may guide me towards better direction in some cases. Here is the original report:

image

So I fixed those via:

  • symfony/service-contracts - used string usage just like the Nette one beside that
  • symfony/yaml - added as dev dependency as it is used in tests
  • nette/robot-loader - moved to require as it is used in utils
  • rector/rector-downgrade-php - marked build/config as prod path for the analyser (is that correct?)
  • fidry/cpu-core-counter - removed, it really looks unused (wondering why composer-unused you have in CI didnt find this)
  • react/promise - removed, felt unused too

Let me know if you want to adjust any of that. I also added this tool to CI to prevent similar issues in future.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@samsonasik samsonasik merged commit a16a04d into rectorphp:main Apr 4, 2024
40 checks passed
@samsonasik
Copy link
Member

Thank you @janedbal

@TomasVotruba
Copy link
Member

Thank you for all the extensive effort to make this pass @janedbal 🙏 Great package 👍

@TomasVotruba
Copy link
Member

@janedbal Hey, I wanted to say thank you - it works perfectly 👏 + Love the PHP config!
Just spotted unused package in #5998 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants