Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Fix array callable with constructor args #5770

Merged
merged 3 commits into from
Mar 24, 2024
Merged

[DeadCode] Fix array callable with constructor args #5770

merged 3 commits into from
Mar 24, 2024

Conversation

hogejiro
Copy link
Contributor

@hogejiro
run fix-cs
f25c513
@hogejiro
[DeadCode] Skip Array Callable dynamic method while defining a constr…
d300634 
…uctor without default args on RemoveUnusedPrivateMethodRector
@samsonasik
Copy link
Member

Let's give it a try, thank you @hogejiro

@samsonasik samsonasik merged commit fc250dd into rectorphp:main Mar 24, 2024
39 checks passed
@hogejiro hogejiro deleted the fix_array_callable_with_constructor_args branch March 24, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of RemoveUnusedPrivateMethodRector
2 participants
@hogejiro @samsonasik