Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Add Function_ support on ExplicitReturnNullRector #5762

Merged
merged 3 commits into from
Mar 23, 2024
Merged

[CodeQuality] Add Function_ support on ExplicitReturnNullRector #5762

merged 3 commits into from
Mar 23, 2024

Conversation

samsonasik
Copy link
Member

per description, it should support function as well

rector-src/rules/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector.php

Line 47 in 97e2433

'Add explicit return null to method/function that returns a value, but missed main return',

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit c45f0e2 into main Mar 23, 2024
41 checks passed
@samsonasik samsonasik deleted the ad-funciton branch March 23, 2024 06:36
@TomasVotruba
Copy link
Member

Awesome, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba