Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQuality] Skip __construct() method on ExplicitReturnNullRector #5758

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

samsonasik
Copy link
Member

Return_'s Expr is removed on __construct() by rule: RemoveUselessReturnExprInConstructRector, see

https://getrector.com/demo/f8805b08-85cc-4052-a46d-23009d0ef575

so this need to be skipped on ExplicitReturnNullRector

@samsonasik samsonasik merged commit b042152 into main Mar 22, 2024
40 of 41 checks passed
@samsonasik samsonasik deleted the skip-construct branch March 22, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant